Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2752123002: [LayoutNG] Move NGFloatingObject off Oilpan (Closed)
Patch Set: more comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
index 773af5f0e1161bb0defba4428527b3e2bb15857b..af0c901f543b1fc38621638228709ac0ae77d1d7 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
@@ -239,8 +239,9 @@ void NGBlockNode::CopyFragmentDataToLayoutBox(
// We may still have unpositioned floats when we reach the root box.
if (!layout_box_->parent()) {
- for (const auto& floating_object : fragment->PositionedFloats()) {
- FloatingObjectPositionedUpdated(floating_object, layout_box_);
+ for (const RefPtr<NGFloatingObject>& floating_object :
+ fragment->PositionedFloats()) {
+ FloatingObjectPositionedUpdated(floating_object.get(), layout_box_);
}
}
@@ -248,10 +249,11 @@ void NGBlockNode::CopyFragmentDataToLayoutBox(
if (child_fragment->IsPlaced())
FragmentPositionUpdated(toNGPhysicalBoxFragment(*child_fragment));
- for (const auto& floating_object :
+ for (const RefPtr<NGFloatingObject>& floating_object :
toNGPhysicalBoxFragment(child_fragment.get())->PositionedFloats()) {
FloatingObjectPositionedUpdated(
- floating_object, toLayoutBox(child_fragment->GetLayoutObject()));
+ floating_object.get(),
+ toLayoutBox(child_fragment->GetLayoutObject()));
}
}

Powered by Google App Engine
This is Rietveld 408576698