chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2752113005: Let ImeAdapterAndroid have the same lifecycle as its Java peer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2752113005: Let ImeAdapterAndroid have the same lifecycle as its Java peer (Closed)

Patch Set: fix tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 5623df08703de7d5b766f1edca9a398e92bcbe10..ed0bc3c71ce1d32da7413075e15f9a9f9cac92cf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -2321,8 +2321,6 @@ public class Tab

newContentViewCore.onShow();

setContentViewCore(newContentViewCore);

- mContentViewCore.attachImeAdapter();

// If the URL has already committed (e.g. prerendering), tell process management logic that

// it can rely on the process visibility signal for binding management.

// TODO: Call ChildProcessLauncher#determinedVisibility() at a more intuitive time.