chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java - Issue 2752113005: Let ImeAdapterAndroid have the same lifecycle as its Java peer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

Issue 2752113005: Let ImeAdapterAndroid have the same lifecycle as its Java peer (Closed)

Patch Set: comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | content/browser/BUILD.gn » ('j') | content/browser/android/ime_adapter_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

index 8978f83da8c74e14ea100c98cdd0dce2e11548a3..e452e88e1bd10d79f043a531f377dc30b3a7b1c8 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

@@ -89,9 +89,8 @@ public class ContextualSearchTapEventTest extends ChromeActivityTestCaseBase<Chr

super(activity, windowAndroid, null);

setSelectionController(new MockCSSelectionController(activity, this));

ContentViewCore contentView = getSelectionController().getBaseContentView();

- contentView.setSelectionPopupControllerForTesting(

- new SelectionPopupController(activity, null, null, null,

- contentView.getRenderCoordinates(), null));

+ contentView.setSelectionPopupControllerForTesting(new SelectionPopupController(

+ activity, null, null, null, contentView.getRenderCoordinates()));

contentView.setSelectionClient(this);

MockContextualSearchPolicy policy = new MockContextualSearchPolicy();

setContextualSearchPolicy(policy);