content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java - Issue 2752113005: Let ImeAdapterAndroid have the same lifecycle as its Java peer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

Issue 2752113005: Let ImeAdapterAndroid have the same lifecycle as its Java peer (Closed)

Patch Set: background rwhva Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('K') | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

index ae53c847293e0d35ae3d7bb650375720b1a156a2..ea84e66934fb70523964b044e3a5153c3706c8dd 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

@@ -82,9 +82,8 @@ public class PopupZoomerTest extends ContentShellTestBase {

mContentViewCore = new ContentViewCore(getActivity(), "");

ImeAdapter imeAdapter = new ImeAdapter(new TestInputMethodManagerWrapper(mContentViewCore),

new TestImeAdapterDelegate(getContentViewCore().getContainerView()));

- mContentViewCore.setSelectionPopupControllerForTesting(

- new SelectionPopupController(getActivity(), null, null, null,

- mContentViewCore.getRenderCoordinates(), imeAdapter));

+ mContentViewCore.setSelectionPopupControllerForTesting(new SelectionPopupController(

+ getActivity(), null, null, null, mContentViewCore.getRenderCoordinates()));

mContentViewCore.setPopupZoomerForTest(mPopupZoomer);

mContentViewCore.setImeAdapterForTest(imeAdapter);

}