Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/web_contents/web_contents_view_android.cc

Issue 2752113005: Let ImeAdapterAndroid have the same lifecycle as its Java peer (Closed)
Patch Set: background rwhva Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/renderer_host/render_widget_host_view_android.cc ('K') | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_android.cc
diff --git a/content/browser/web_contents/web_contents_view_android.cc b/content/browser/web_contents/web_contents_view_android.cc
index 7791bf71393b68e80e6e7fc538730a33dfb5de02..2f15fcc947eeffc6c4e8046ad9fee6deef0c6af8 100644
--- a/content/browser/web_contents/web_contents_view_android.cc
+++ b/content/browser/web_contents/web_contents_view_android.cc
@@ -186,7 +186,7 @@ void WebContentsViewAndroid::Focus() {
if (web_contents_->ShowingInterstitialPage()) {
web_contents_->GetInterstitialPage()->Focus();
if (content_view_core_)
- content_view_core_->ForceUpdateImeAdapter(rwhv->GetNativeImeAdapter());
+ rwhv->ConnectImeAdapter(content_view_core_->ime_adapter());
boliu 2017/03/24 17:13:16 ditto, is this still needed?
Jinsuk Kim 2017/03/27 03:19:33 No. removed.
} else {
rwhv->Focus();
}
« content/browser/renderer_host/render_widget_host_view_android.cc ('K') | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698