Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/WebKit/Source/modules/plugins/PluginArray.idl

Issue 2752103003: Make item and namedItem args in MimeTypeArray/PluginArray/Plugin non-optional (Closed)
Patch Set: Codereview update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/plugins/PluginArray.idl
diff --git a/third_party/WebKit/Source/modules/plugins/PluginArray.idl b/third_party/WebKit/Source/modules/plugins/PluginArray.idl
index 5bcbbcfad0306f9ed29a37c77d44be5e6c5d1413..ce4d6167b887c8ae9fd217e03717408a03fcfbb0 100644
--- a/third_party/WebKit/Source/modules/plugins/PluginArray.idl
+++ b/third_party/WebKit/Source/modules/plugins/PluginArray.idl
@@ -24,8 +24,8 @@
ImplementedAs=DOMPluginArray
] interface PluginArray {
readonly attribute unsigned long length;
- getter Plugin? item([Default=Undefined] optional unsigned long index);
- Plugin? namedItem([Default=Undefined] optional DOMString name);
- [NotEnumerable, ImplementedAs=namedItem] getter Plugin ([Default=Undefined] optional DOMString name);
+ getter Plugin? item(unsigned long index);
+ [NotEnumerable] getter Plugin? namedItem(DOMString name);
foolip 2017/03/21 08:57:52 Same issues here, can match spec almost verbatim I
+ // [NotEnumerable, ImplementedAs=namedItem] getter Plugin ([Default=Undefined] optional DOMString name);
void refresh([Default=Undefined] optional boolean reload);
};

Powered by Google App Engine
This is Rietveld 408576698