Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: third_party/WebKit/Source/modules/plugins/MimeTypeArray.idl

Issue 2752103003: Make item and namedItem args in MimeTypeArray/PluginArray/Plugin non-optional (Closed)
Patch Set: Codereview update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/plugins/MimeTypeArray.idl
diff --git a/third_party/WebKit/Source/modules/plugins/MimeTypeArray.idl b/third_party/WebKit/Source/modules/plugins/MimeTypeArray.idl
index 9854da4f32dd14426342ce700d678642db08438c..5344fddc2b4e61b2e6f1042001e12782ccefdbc5 100644
--- a/third_party/WebKit/Source/modules/plugins/MimeTypeArray.idl
+++ b/third_party/WebKit/Source/modules/plugins/MimeTypeArray.idl
@@ -18,11 +18,13 @@
Boston, MA 02110-1301, USA.
*/
+// https://html.spec.whatwg.org/multipage/webappapis.html#mimetypearray
+
[
ImplementedAs=DOMMimeTypeArray
] interface MimeTypeArray {
readonly attribute unsigned long length;
- getter MimeType item([Default=Undefined] optional unsigned long index);
- MimeType namedItem([Default=Undefined] optional DOMString name);
- [NotEnumerable, ImplementedAs=namedItem] getter MimeType ([Default=Undefined] optional DOMString name);
+ // TODO(lunalu): the return type should be nullable.
foolip 2017/03/21 08:57:52 You can just make that change, it won't affect the
+ getter MimeType item(unsigned long index);
+ [NotEnumerable] getter MimeType namedItem(DOMString name);
};

Powered by Google App Engine
This is Rietveld 408576698