Remove support for SK_CROP_RECT_IS_INT, now that it is no longer used in Blink or Chrome.

include/core/SkImageFilter.h

Index: include/core/SkImageFilter.h
diff --git a/include/core/SkImageFilter.h b/include/core/SkImageFilter.h
index 9f0e29939114085d627aeb50e320f3fad9731566..3b726f5745f8b36b47d6aae4c6036631a8fe76df 100644
--- a/include/core/SkImageFilter.h
+++ b/include/core/SkImageFilter.h
@@ -31,9 +31,6 @@ class SK_API SkImageFilter : public SkFlattenable {
 public:
     SK_DECLARE_INST_COUNT(SkImageFilter)
 
-#ifdef SK_CROP_RECT_IS_INT
-    typedef SkIRect CropRect;
-#else
     struct CropRect {
         SkRect fRect;
         uint32_t fFlags;

[reed1, 2013/10/16 14:51:53]

Is your longer-term plan to keep these fields exposed, or to wrap/hide them, in
the spirit of other structs like SkRRect?

[Stephen White, 2013/10/16 14:57:15]

I was going to leave it as a struct, in the spirit of SkRect.

[reed1, 2013/10/16 14:59:27]

Not sure if you're serious, but rect doesn't have bitfields in a flag-int.
Everywhere we have that sort of sophistication, we usually guard it (e.g. Paint,
Matrix), where we care about the client not writing undefined bits.

@@ -51,7 +48,6 @@ public:
             return fFlags != 0x0;
         }
     };
-#endif
 
     class Proxy {
     public:
@@ -160,11 +156,7 @@ public:
      *  "offset" parameter in onFilterImage and filterImageGPU(). (The latter
      *  ensures that the resulting buffer is drawn in the correct location.)
      */
-#ifdef SK_CROP_RECT_IS_INT
-    bool cropRectIsSet() const { return !fCropRect.isLargest(); }
-#else
     bool cropRectIsSet() const { return fCropRect.isSet(); }
-#endif
 
 protected:
     SkImageFilter(int inputCount, SkImageFilter** inputs, const CropRect* cropRect = NULL);