Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2752093002: Allow AstBuilder to report parse errors. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -10 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/analyzer_diet_listener.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 3 chunks +26 lines, -3 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 9 months ago (2017-03-15 19:56:56 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-15 20:34:32 UTC) #2
ahe
lgtm
3 years, 9 months ago (2017-03-16 13:28:44 UTC) #3
scheglov
3 years, 9 months ago (2017-03-16 20:52:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcfe68f0576fe481626ccd4fedf06c375dcc22ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698