Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2752063002: Remove JumpListIconsOld directory and set upper limit for delete attempts (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/browser/win/jumplist.cc ('K') | « chrome/browser/win/jumplist.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index fb8d14342f443f70ddd12bf7398fe7d822cf87a8..11985d082e34bfeb57bb89638801545fcd564503 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -79856,6 +79856,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>The type of category clicked in the Windows Jumplist</summary>
</histogram>
+<histogram name="WinJumplist.DeleteStatusJumpListIcons"
+ enum="JumplisticonsDeleteCategory">
+ <owner>chengx@chromium.org</owner>
+ <summary>
+ This metric records the detailed delete result of JumpListIcons directory.
+ Please refer to JumplisticonsDeleteCategory for more information.
Ilya Sherman 2017/03/21 20:56:45 There is no need for the second sentence here -- i
chengx 2017/03/22 06:46:28 Done.
+ </summary>
+</histogram>
+
+<histogram name="WinJumplist.DeleteStatusJumpListIconsOld"
+ enum="JumplisticonsDeleteCategory">
+ <owner>chengx@chromium.org</owner>
+ <summary>
+ This metric records the detailed delete result of JumpListIconsOld
+ directory. Please refer to JumplisticonsDeleteCategory for more information.
+ </summary>
+</histogram>
+
<histogram name="WinJumplist.DetailedFolderMoveResults"
enum="JumplistIconsDetailedFolderMoveCategory">
<obsolete>
@@ -79893,6 +79911,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="WinJumplist.DetailedFolderResultsDeleteUpdated"
enum="JumplistIconsDetailedFolderOperationDeleteUpdatedCategory">
+ <obsolete>
+ Obselete 03/20/2016. New metrics named WinJumplist.DeleteStatusJumpListIcons
+ and WinJumplist.DeleteStatusJumpListIconsOld are used instead.
+ </obsolete>
<owner>chengx@chromium.org</owner>
<summary>
This metric is recorded when folders JumpListIcons and JumpListIconsOld get
@@ -97598,6 +97620,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</int>
</enum>
+<enum name="JumplisticonsDeleteCategory" type="int">
+ <int value="0" label="Success"/>
+ <int value="1" label="Fail as folder name length exceeds MAX_PATH"/>
+ <int value="2" label="Fail as folder is read-only"/>
+ <int value="3" label="Fail to delete maximum files allowed with no failures"/>
+ <int value="4" label="Fail to delete maximum files allowed"/>
Ilya Sherman 2017/03/21 20:56:45 I don't understand the difference between these tw
chengx 2017/03/22 06:46:28 Alright, I have renamed those two labels. Basicall
+</enum>
+
<enum name="JumplistIconsDetailedFolderMoveCategory" type="int">
<int value="0"
label="DelTargetDir Succeed - MoveFileEx Succeed - CopyFile Succeed -
« chrome/browser/win/jumplist.cc ('K') | « chrome/browser/win/jumplist.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698