Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: runtime/vm/assembler_x64.cc

Issue 2752013003: Improve instruction scheduling when calling the store buffer stub. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // NOLINT 5 #include "vm/globals.h" // NOLINT
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/heap.h" 10 #include "vm/heap.h"
(...skipping 2935 matching lines...) Expand 10 before | Expand all | Expand 10 after
2946 StoreIntoObjectFilter(object, value, &done); 2946 StoreIntoObjectFilter(object, value, &done);
2947 } else { 2947 } else {
2948 StoreIntoObjectFilterNoSmi(object, value, &done); 2948 StoreIntoObjectFilterNoSmi(object, value, &done);
2949 } 2949 }
2950 // A store buffer update is required. 2950 // A store buffer update is required.
2951 if (value != RDX) pushq(RDX); 2951 if (value != RDX) pushq(RDX);
2952 if (object != RDX) { 2952 if (object != RDX) {
2953 movq(RDX, object); 2953 movq(RDX, object);
2954 } 2954 }
2955 pushq(CODE_REG); 2955 pushq(CODE_REG);
2956 movq(TMP, Address(THR, Thread::update_store_buffer_entry_point_offset()));
2956 movq(CODE_REG, Address(THR, Thread::update_store_buffer_code_offset())); 2957 movq(CODE_REG, Address(THR, Thread::update_store_buffer_code_offset()));
2957 movq(TMP, Address(THR, Thread::update_store_buffer_entry_point_offset()));
2958 call(TMP); 2958 call(TMP);
2959 2959
2960 popq(CODE_REG); 2960 popq(CODE_REG);
2961 if (value != RDX) popq(RDX); 2961 if (value != RDX) popq(RDX);
2962 Bind(&done); 2962 Bind(&done);
2963 } 2963 }
2964 2964
2965 2965
2966 void Assembler::StoreIntoObjectNoBarrier(Register object, 2966 void Assembler::StoreIntoObjectNoBarrier(Register object,
2967 const Address& dest, 2967 const Address& dest,
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
3799 3799
3800 3800
3801 const char* Assembler::FpuRegisterName(FpuRegister reg) { 3801 const char* Assembler::FpuRegisterName(FpuRegister reg) {
3802 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 3802 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
3803 return xmm_reg_names[reg]; 3803 return xmm_reg_names[reg];
3804 } 3804 }
3805 3805
3806 } // namespace dart 3806 } // namespace dart
3807 3807
3808 #endif // defined TARGET_ARCH_X64 3808 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698