Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2751983002: Pending renames and cleanups after commits (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pending renames and cleanups after commits Committed: https://github.com/dart-lang/sdk/commit/cb8b56523ca52347c0341867a38e03f065d76771

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -205 lines) Patch
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 17 chunks +33 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 5 chunks +4 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 9 chunks +16 lines, -17 lines 1 comment Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 6 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 8 chunks +14 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 11 chunks +27 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
TBR
3 years, 9 months ago (2017-03-15 14:33:10 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as cb8b56523ca52347c0341867a38e03f065d76771 (presubmit successful).
3 years, 9 months ago (2017-03-15 14:33:52 UTC) #4
Johnni Winther
ping
3 years, 9 months ago (2017-03-16 09:03:52 UTC) #5
Siggi Cherem (dart-lang)
3 years, 9 months ago (2017-03-17 23:50:55 UTC) #6
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2751983002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/native_data.dart (right):

https://codereview.chromium.org/2751983002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/native_data.dart:223: final NativeBasicData
_nativeBaseData;
should the variable be BasicData too? I have a feeling you did that in a
following CL, though.

Powered by Google App Engine
This is Rietveld 408576698