third_party/WebKit/Source/core/loader/PingLoader.cpp - Issue 2751953002: sendBeacon(): once transmission allowance has been reached, always fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.cpp

Issue 2751953002: sendBeacon(): once transmission allowance has been reached, always fail. (Closed)

Patch Set: fix test description imprecision Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/PingLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/PingLoader.cpp b/third_party/WebKit/Source/core/loader/PingLoader.cpp

index e9cddb9b2385cf0f7c36e00878fa6207edcae0d6..cb6542d3d1ef5c6aa7a6acf3adf6f3f74a49aef4 100644

--- a/third_party/WebKit/Source/core/loader/PingLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/PingLoader.cpp

@@ -426,7 +426,7 @@ bool sendBeaconCommon(LocalFrame* frame,

return false;

unsigned long long entitySize = beacon.size();

- if (allowance > 0 && static_cast<unsigned long long>(allowance) < entitySize)

+ if (allowance < 0 || static_cast<unsigned long long>(allowance) < entitySize)

return false;

payloadLength = entitySize;

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance-limit.html ('k') | no next file » | no next file with comments »