Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 275193002: Whitelist experimental bookmarks extensions for fileSystem APIs (Closed)

Created:
6 years, 7 months ago by Mike Wittman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Whitelist experimental bookmarks extensions for fileSystem APIs These APIs are used to enable bookmarks export functionality. BUG=312900, 319444, 371562, 372039

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike Wittman
6 years, 7 months ago (2014-05-09 19:43:47 UTC) #1
not at google - send to devlin
lgtm but where in the bug(s) does it explain why you need these permissions?
6 years, 7 months ago (2014-05-09 21:34:29 UTC) #2
Mike Wittman
On 2014/05/09 21:34:29, kalman wrote: > lgtm but where in the bug(s) does it explain ...
6 years, 7 months ago (2014-05-09 22:03:28 UTC) #3
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 7 months ago (2014-05-09 23:20:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/275193002/20001
6 years, 7 months ago (2014-05-09 23:23:06 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 01:03:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 01:08:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/3101) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66963) ios_dbg_simulator ...
6 years, 7 months ago (2014-05-10 01:08:08 UTC) #8
Mike Wittman
6 years, 7 months ago (2014-05-12 18:31:47 UTC) #9
This was committed at r269453.

Powered by Google App Engine
This is Rietveld 408576698