Clean up documentation of Platform in dart:io.

Clean up documentation of Platform in dart:io.

The class is just a static-only container, and should really be rewritten as
either top-level getters instead of static getters, or as instance getters
on an interface (in case we ever want to mock it).

Also, the isOSName getters for each individual supported OS doesn't scale.
We should consider removing them and only support the `operatingSystem` getter.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/08beb9eadfcca8c916c77817da8dcdf7481639e6

[Lasse Reichstein Nielsen, 2017-03-17 09:43:23]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-03-17 15:52:37]

LGTM.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart
File sdk/lib/io/platform.dart (right):

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:101: * version of Linux that identifies itself by a
different name, e.g., Android.
don't use "e.g."

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:106: * Whether the operating system is a version of
[macOS](https://en.wikipedia.org/wiki/MacOS).
long line.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:111: * Whether the operating system is a version of
[Microsoft Windows](https://en.wikipedia.org/wiki/Microsoft_Windows).
long line.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:116: * Whether the operating system is a version of
[Android](https://en.wikipedia.org/wiki/Android_(operating_system)).
long line.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:121: * Whether the operating system is a version of
[iOS](https://en.wikipedia.org/wiki/IOS).
long line.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:126: * Whether the operating system is a version of
[Fuchsia](https://en.wikipedia.org/wiki/Google_Fuchsia).
lon line.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:154: * The path is the literal path used to run the
script. This
The literal path used to run the script.

[jensj, 2017-03-20 07:42:29]

jensj@google.com changed reviewers:
+ jensj@google.com

[jensj, 2017-03-20 07:42:30]

dbc. Missed a "T".

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart
File sdk/lib/io/platform.dart (right):

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:82: * Te path separator used by the operating system to
separate
"The"?

[Lasse Reichstein Nielsen, 2017-04-04 07:24:46]

Description was changed from

==========
Clean up documentation of Platform in dart:io.

The class is just a static-only container, and should really be rewritten as
either top-level getters instead of static getters, or as instance getters
on an interface (in case we ever want to mock it).

Also, the isOSName getters for each individual supported OS doesn't scale.
We should consider removing them and only support the `operatingSystem` getter.
==========

to

==========
Clean up documentation of Platform in dart:io.

The class is just a static-only container, and should really be rewritten as
either top-level getters instead of static getters, or as instance getters
on an interface (in case we ever want to mock it).

Also, the isOSName getters for each individual supported OS doesn't scale.
We should consider removing them and only support the `operatingSystem` getter.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/08beb9eadfcca8c916c77817da8dcdf7481639e6
==========

[Lasse Reichstein Nielsen, 2017-04-04 07:24:47]

Committed patchset #2 (id:20001) manually as
08beb9eadfcca8c916c77817da8dcdf7481639e6 (presubmit successful).

[Lasse Reichstein Nielsen, 2017-04-04 07:25:15]

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart
File sdk/lib/io/platform.dart (right):

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:82: * Te path separator used by the operating system to
separate
On 2017/03/20 07:42:30, jensj wrote:
> "The"?

Done.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:101: * version of Linux that identifies itself by a
different name, e.g., Android.
On 2017/03/17 15:52:37, floitsch wrote:
> don't use "e.g."

Done.

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:106: * Whether the operating system is a version of
[macOS](https://en.wikipedia.org/wiki/MacOS).
Turns out that it works if you break the line before the "[".

https://codereview.chromium.org/2751913006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:154: * The path is the literal path used to run the
script. This
On 2017/03/17 15:52:37, floitsch wrote:
> The literal path used to run the script.

Done.