Parse constructor field initializers with Fasta.

Parse constructor field initializers with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/39dbb75c763985e7820b4463e40786598c7a185f

[Paul Berry, 2017-03-15 16:07:21]

lgtm

[scheglov, 2017-03-15 18:32:58]

Description was changed from

==========
Parse constructor field initializers with Fasta.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Parse constructor field initializers with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/39dbb75c763985e7820b4463e40786598c7a185f
==========

[scheglov, 2017-03-15 18:32:59]

Committed patchset #2 (id:20001) manually as
39dbb75c763985e7820b4463e40786598c7a185f (presubmit successful).

[ahe, 2017-04-06 14:25:21]

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:498: if
(listener.stack.length == 1) {
Could you explain what this is for?

[scheglov, 2017-04-06 15:51:55]

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:498: if
(listener.stack.length == 1) {
On 2017/04/06 14:25:21, ahe wrote:
> Could you explain what this is for?

AstBuilder puts more data on the stack than the other parser.

[ahe, 2017-04-06 15:57:32]

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:498: if
(listener.stack.length == 1) {
On 2017/04/06 15:51:55, scheglov wrote:
> On 2017/04/06 14:25:21, ahe wrote:
> > Could you explain what this is for?
> 
> AstBuilder puts more data on the stack than the other parser.

Would it be possible to not do that? I'm trying to maintain the invariant that
the stack is null after parsing a function. This helps catch errors.

[scheglov, 2017-04-06 16:06:05]

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:498: if
(listener.stack.length == 1) {
On 2017/04/06 15:57:32, ahe wrote:
> On 2017/04/06 15:51:55, scheglov wrote:
> > On 2017/04/06 14:25:21, ahe wrote:
> > > Could you explain what this is for?
> > 
> > AstBuilder puts more data on the stack than the other parser.
> 
> Would it be possible to not do that? I'm trying to maintain the invariant that
> the stack is null after parsing a function. This helps catch errors.

The stack is empty after parsing a function.
But it is not empty after removing a function body.

[ahe, 2017-05-31 14:15:38]

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:498: if
(listener.stack.length == 1) {
On 2017/04/06 16:06:05, scheglov wrote:
> On 2017/04/06 15:57:32, ahe wrote:
> > On 2017/04/06 15:51:55, scheglov wrote:
> > > On 2017/04/06 14:25:21, ahe wrote:
> > > > Could you explain what this is for?
> > > 
> > > AstBuilder puts more data on the stack than the other parser.
> > 
> > Would it be possible to not do that? I'm trying to maintain the invariant
that
> > the stack is null after parsing a function. This helps catch errors.
> 
> The stack is empty after parsing a function.
> But it is not empty after removing a function body.

What do you mean by removing a function body?

[scheglov, 2017-05-31 21:46:20]

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:498: if
(listener.stack.length == 1) {
On 2017/05/31 14:15:38, ahe wrote:
> On 2017/04/06 16:06:05, scheglov wrote:
> > On 2017/04/06 15:57:32, ahe wrote:
> > > On 2017/04/06 15:51:55, scheglov wrote:
> > > > On 2017/04/06 14:25:21, ahe wrote:
> > > > > Could you explain what this is for?
> > > > 
> > > > AstBuilder puts more data on the stack than the other parser.
> > > 
> > > Would it be possible to not do that? I'm trying to maintain the invariant
> that
> > > the stack is null after parsing a function. This helps catch errors.
> > 
> > The stack is empty after parsing a function.
> > But it is not empty after removing a function body.
> 
> What do you mean by removing a function body?

The statement "var body = listener.pop();" removes a function body from the
stack.

[ahe, 2017-06-01 12:13:02]

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2751913002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:498: if
(listener.stack.length == 1) {
On 2017/05/31 21:46:20, scheglov wrote:
> On 2017/05/31 14:15:38, ahe wrote:
> > On 2017/04/06 16:06:05, scheglov wrote:
> > > On 2017/04/06 15:57:32, ahe wrote:
> > > > On 2017/04/06 15:51:55, scheglov wrote:
> > > > > On 2017/04/06 14:25:21, ahe wrote:
> > > > > > Could you explain what this is for?
> > > > > 
> > > > > AstBuilder puts more data on the stack than the other parser.
> > > > 
> > > > Would it be possible to not do that? I'm trying to maintain the
invariant
> > that
> > > > the stack is null after parsing a function. This helps catch errors.
> > > 
> > > The stack is empty after parsing a function.
> > > But it is not empty after removing a function body.
> > 
> > What do you mean by removing a function body?
> 
> The statement "var body = listener.pop();" removes a function body from the
> stack.

I see. After calling parseFunctionBody, there should only be one thing on the
stack: the function body. That's the invariant that I'm maintaining here.