Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2751903003: DoubleTap Zoom support for Mobile Viewport pages (Closed)

Created:
3 years, 9 months ago by sujith
Modified:
3 years, 7 months ago
Reviewers:
rjkroege, johnme, bokan
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DoubleTap Zoom support for Mobile Viewport pages In case of ForceEnableZoom, MobileVieport pages not supporting doubleTapZoom. So added patch to support it. BUG=701796 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M content/browser/renderer_host/frame_metadata_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/frame_metadata_util.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sujith
PTAL
3 years, 9 months ago (2017-03-15 15:50:38 UTC) #2
johnme
+bokan, who owns zooming/viewports What would double-tap zoom achieve on mobile (width=device-width) pages? Desktop pages ...
3 years, 9 months ago (2017-03-15 17:05:16 UTC) #4
bokan
I generally agree with John that this probably isn't super useful. In principle I do ...
3 years, 9 months ago (2017-03-15 18:26:24 UTC) #5
sujith
On 2017/03/15 18:26:24, bokan wrote: > I generally agree with John that this probably isn't ...
3 years, 9 months ago (2017-03-16 06:39:36 UTC) #6
bokan
3 years, 9 months ago (2017-03-16 12:07:34 UTC) #7
On 2017/03/16 06:39:36, sujith wrote:
> On 2017/03/15 18:26:24, bokan wrote:
> > I generally agree with John that this probably isn't super useful. In
> principle
> > I do find it inconsistent that force zoom allows pinch-zoom but not
double-tap
> > to zoom. IMO, the same arguments apply to pinch-zoom as to double-tap to
zoom.
> > 
> > The one down side I see is that this would reinstate the 300ms click delay,
> > right? I would guess many users have "force zoom" on just to enable zoom on
a
> > few specific sites. I think, on-balance, adding back the 300ms delay is
> probably
> > a worse outcome than enabling double-tap zoom in these niche cases.
> 
> @bokan,
> yeah this patch will reinstate the 300ms click delay, if user enable force
zoom.
> I thought for force zoom, both double tap and pinch zoom should work,
> that's why i raised this patch.
> 
> Could you please close the bug, i don't have permission to do it.

Done. Sorry to sink your patch after you've done it but I think this is the
right choice. Thanks anyway though, it's not obvious what's "correct" here.

Powered by Google App Engine
This is Rietveld 408576698