Issue 27519002: Have Node::ensureRareData() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27519002: Have Node::ensureRareData() return a reference (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent, adamk

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Node::ensureRareData() return a reference Have Node::ensureRareData() return a reference instead of a pointer as it can never return null. This makes the calling code look safer. R=tkent BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159864

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -72 lines)			Patch
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/Element.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View	19 chunks	+51 lines, -51 lines	0 comments	Download
M	Source/core/dom/Node.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Node.cpp	View	8 chunks	+13 lines, -13 lines	0 comments	Download
M	Source/core/html/LabelableElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27519002/1

7 years, 2 months ago (2013-10-16 17:21:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27519002/1

7 years, 2 months ago (2013-10-16 20:43:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27519002/1

7 years, 2 months ago (2013-10-17 01:37:31 UTC) #5

Message was sent while issue was closed.

Change committed as 159864

Expand Messages | Collapse Messages