net/reporting/reporting_observer.cc - Issue 2751883003: Reporting: Implement serializer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/reporting/reporting_observer.cc

Issue 2751883003: Reporting: Implement serializer. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/reporting/reporting_observer.h"	5 #include "net/reporting/reporting_observer.h"

6	6

7 namespace net {	7 namespace net {

8	8

	9 void ReportingObserver::OnContextInitializing() {}

	10

	11 void ReportingObserver::OnContextInitialized() {}
	shivanisha 2017/04/10 18:29:29 There's no implementation of this in any of the ob There's no implementation of this in any of the observers? Will the ReportingGarbageCollectorImpl need to implement any of these? Julia Tuttle 2017/04/11 19:20:46 The DeliveryAgent will need to implement OnContext Show quoted text On 2017/04/10 18:29:29, shivanisha wrote: > There's no implementation of this in any of the observers? > Will the ReportingGarbageCollectorImpl need to implement any of these? The DeliveryAgent will need to implement OnContextInitialized to examine queued reports from prior sessions (if any; currently our default policy prohibits persisting them) and attempt to deliver them. The GarbageCollector could also use it as the first time to do garbage collection. Come to think of it, though, there's a pretty particular order in which the classes should be initialized (Persister, then GarbageCollector, then DeliveryAgent), so maybe I should just hard-code that instead of using observer callbacks.
	12

9 void ReportingObserver::OnCacheUpdated() {}	13 void ReportingObserver::OnCacheUpdated() {}

10	14

11 ReportingObserver::ReportingObserver() {}	15 ReportingObserver::ReportingObserver() {}

12	16

13 ReportingObserver::~ReportingObserver() {}	17 ReportingObserver::~ReportingObserver() {}

14	18

15 } // namespace net	19 } // namespace net

OLD	NEW

« no previous file with comments | « net/reporting/reporting_observer.h ('k') | net/reporting/reporting_persister.h » ('j') | net/reporting/reporting_persister.cc » ('J')