Fix for regression in content shell tests (see b/36131545)

Fix for regression in content shell tests (see b/36131545)

Renamed public fields in class _Closure to make them private fields,
these fields were added to ensure that the offset of _Closure fields
matched up in Dart and C++ (definition of closure object in raw_object.h).

R=regis@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/f748465867a41cf5660ce1d80588cf6edeee3349

[siva, 2017-03-15 00:42:53]

asiva@google.com changed reviewers:
+ regis@google.com, rmacnak@google.com

[rmacnak, 2017-03-15 00:46:28]

On 2017/03/15 00:43:59, siva wrote:

lgtm

Please also add a closure to valueObjects in
tests/lib/mirrors/invocation_fuzz_test.darrt

[regis, 2017-03-15 03:22:07]

lgtm

Thanks for debugging and fixing!

[Bill Hesse, 2017-03-15 12:25:26]

Description was changed from

==========
Fix for regression in content shell tests (see b/36131545)

Renamed public fields in class _Closure to make them private fields,
these fields were added to ensure that the offset of _Closure fields
matched up in Dart and C++ (definition of closure object in raw_object.h).
==========

to

==========
Fix for regression in content shell tests (see b/36131545)

Renamed public fields in class _Closure to make them private fields,
these fields were added to ensure that the offset of _Closure fields
matched up in Dart and C++ (definition of closure object in raw_object.h).
==========

[siva, 2017-03-15 17:03:37]

On 2017/03/15 00:46:28, rmacnak wrote:
> On 2017/03/15 00:43:59, siva wrote:
> 
> lgtm
> 
> Please also add a closure to valueObjects in
> tests/lib/mirrors/invocation_fuzz_test.darrt

Will add the test in another CL and land this so that the google3 roll can
happen

[siva, 2017-03-15 17:06:34]

Description was changed from

==========
Fix for regression in content shell tests (see b/36131545)

Renamed public fields in class _Closure to make them private fields,
these fields were added to ensure that the offset of _Closure fields
matched up in Dart and C++ (definition of closure object in raw_object.h).
==========

to

==========
Fix for regression in content shell tests (see b/36131545)

Renamed public fields in class _Closure to make them private fields,
these fields were added to ensure that the offset of _Closure fields
matched up in Dart and C++ (definition of closure object in raw_object.h).

R=regis@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f748465867a41cf5660ce1d80588cf6edeee3349
==========

[siva, 2017-03-15 17:06:37]

Committed patchset #1 (id:1) manually as
f748465867a41cf5660ce1d80588cf6edeee3349 (presubmit successful).