Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2389)

Unified Diff: cc/playback/float_clip_display_item.h

Issue 2751833007: cc: Move DisplayItem::Raster up to DisplayItemList (Closed)
Patch Set: virtualraster: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/filter_display_item.cc ('k') | cc/playback/float_clip_display_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/float_clip_display_item.h
diff --git a/cc/playback/float_clip_display_item.h b/cc/playback/float_clip_display_item.h
index 1f68cef36e10b5c76f48a6f30caf3aa7c094b24d..7c3362c84416bc5edbdb26a8b73035ca32bf5c77 100644
--- a/cc/playback/float_clip_display_item.h
+++ b/cc/playback/float_clip_display_item.h
@@ -7,16 +7,10 @@
#include <stddef.h>
-#include <memory>
-#include <vector>
-
-#include "base/memory/ptr_util.h"
#include "cc/base/cc_export.h"
#include "cc/playback/display_item.h"
#include "ui/gfx/geometry/rect_f.h"
-class SkCanvas;
-
namespace cc {
class CC_EXPORT FloatClipDisplayItem : public DisplayItem {
@@ -24,18 +18,10 @@ class CC_EXPORT FloatClipDisplayItem : public DisplayItem {
explicit FloatClipDisplayItem(const gfx::RectF& clip_rect);
~FloatClipDisplayItem() override;
- void Raster(SkCanvas* canvas,
- SkPicture::AbortCallback* callback) const override;
-
size_t ExternalMemoryUsage() const { return 0; }
int ApproximateOpCount() const { return 1; }
- const gfx::RectF& clip_rect() const { return clip_rect_; }
-
- private:
- void SetNew(const gfx::RectF& clip_rect);
-
- gfx::RectF clip_rect_;
+ const gfx::RectF clip_rect;
};
class CC_EXPORT EndFloatClipDisplayItem : public DisplayItem {
@@ -43,13 +29,6 @@ class CC_EXPORT EndFloatClipDisplayItem : public DisplayItem {
EndFloatClipDisplayItem();
~EndFloatClipDisplayItem() override;
- static std::unique_ptr<EndFloatClipDisplayItem> Create() {
- return base::MakeUnique<EndFloatClipDisplayItem>();
- }
-
- void Raster(SkCanvas* canvas,
- SkPicture::AbortCallback* callback) const override;
-
int ApproximateOpCount() const { return 0; }
};
« no previous file with comments | « cc/playback/filter_display_item.cc ('k') | cc/playback/float_clip_display_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698