Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h

Issue 2751833005: Add Distillation info to Reading List view. (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
index 16d6c2043f317e9f1d66a3a9c7a23e6d6f5e69fc..bb16997d3ca50bf29bc92264986a124bd877a3c8 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
@@ -16,10 +16,10 @@ class GURL;
// Collection view item for representing a ReadingListEntry.
@interface ReadingListCollectionViewItem : CollectionViewItem
-// The main text to display.
-@property(nonatomic, copy) NSString* text;
-// The secondary text to display.
-@property(nonatomic, copy) NSString* detailText;
+// The title to display.
+@property(nonatomic, copy) NSString* title;
+// The subtitle to display. This is often the |url|'s origin.
+@property(nonatomic, copy) NSString* subtitle;
// The URL of the Reading List entry.
@property(nonatomic, readonly) const GURL& url;
// The URL of the page presenting the favicon to display.
@@ -27,6 +27,10 @@ class GURL;
// Status of the offline version.
@property(nonatomic, assign)
ReadingListEntry::DistillationState distillationState;
+// Size of the distilled files.
+@property(nonatomic, assign) int64_t distillationSize;
+// Timestamp of the distillation in microseconds since Jan 1st 1970.
+@property(nonatomic, assign) int64_t distillationDate;
// Delegate for the accessibility actions.
@property(nonatomic, weak)
id<ReadingListCollectionViewItemAccessibilityDelegate>
@@ -51,9 +55,13 @@ class GURL;
@interface ReadingListCell : MDCCollectionViewCell
// Title label.
-@property(nonatomic, readonly, strong) UILabel* textLabel;
-// Detail label.
-@property(nonatomic, readonly, strong) UILabel* detailTextLabel;
+@property(nonatomic, readonly, strong) UILabel* titleLabel;
+// Subtitle label.
+@property(nonatomic, readonly, strong) UILabel* subtitleLabel;
+// Timestamp of the distillation in microseconds since Jan 1st 1970.
+@property(nonatomic, assign) int64_t distillationDate;
+// Size of the distilled files.
+@property(nonatomic, assign) int64_t distillationSize;
// View for displaying the favicon for the reading list entry.
@property(nonatomic, readonly, strong) FaviconViewNew* faviconView;
// Status of the offline version. Updates the visual indicator when updated.

Powered by Google App Engine
This is Rietveld 408576698