Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h

Issue 2751833005: Add Distillation info to Reading List view. (Closed)
Patch Set: clean Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
index 38e9434aee9b3935c58dd4af2dd9ac0505ed1b3d..9992cd1e9b41b700c6d29c116658642701b2272a 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
@@ -17,9 +17,9 @@ class GURL;
@interface ReadingListCollectionViewItem : CollectionViewItem
// The main text to display.
gambard 2017/03/16 07:50:23 Update comment
Olivier 2017/03/16 09:20:14 Done.
-@property(nonatomic, copy) NSString* text;
+@property(nonatomic, copy) NSString* title;
// The secondary text to display.
gambard 2017/03/16 07:50:23 Update comment
Olivier 2017/03/16 09:20:14 Done.
-@property(nonatomic, copy) NSString* detailText;
+@property(nonatomic, copy) NSString* subtitle;
// The URL of the Reading List entry.
@property(nonatomic, readonly) const GURL& url;
// The URL of the page presenting the favicon to display.
@@ -27,6 +27,10 @@ class GURL;
// Status of the offline version.
@property(nonatomic, assign)
ReadingListEntry::DistillationState distillationState;
+// Size of the distilled files.
+@property(nonatomic, assign) int64_t distillationSize;
+// Timestamp of the distillation in microseconds since Jan 1st 1970.
+@property(nonatomic, assign) int64_t distillationDate;
// Delegate for the accessibility actions.
@property(nonatomic, weak)
id<ReadingListCollectionViewItemAccessibilityDelegate>
@@ -50,9 +54,13 @@ class GURL;
@interface ReadingListCell : MDCCollectionViewCell
// Title label.
-@property(nonatomic, readonly, strong) UILabel* textLabel;
+@property(nonatomic, readonly, strong) UILabel* titleLabel;
+// Distilled date label.
+@property(nonatomic, readonly, strong) UILabel* distillationDateLabel;
+// Distilled size label.
+@property(nonatomic, readonly, strong) UILabel* distillationSizeLabel;
// Detail label.
gambard 2017/03/16 07:50:23 Update comment
Olivier 2017/03/16 09:20:14 Done.
-@property(nonatomic, readonly, strong) UILabel* detailTextLabel;
+@property(nonatomic, readonly, strong) UILabel* subtitleLabel;
// View for displaying the favicon for the reading list entry.
@property(nonatomic, readonly, strong) FaviconViewNew* faviconView;

Powered by Google App Engine
This is Rietveld 408576698