Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoader.h

Issue 2751833002: Clean up DocumentWriter creation's FrameLoader interaction (Closed)
Patch Set: Rebase + nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/DocumentLoader.h
diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.h b/third_party/WebKit/Source/core/loader/DocumentLoader.h
index a30b783bd8ce33ef96762f26a80212e11ca57204..62dc9b638f562b1a63c0b3efcb325bcdc58ba40b 100644
--- a/third_party/WebKit/Source/core/loader/DocumentLoader.h
+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.h
@@ -166,10 +166,6 @@ class CORE_EXPORT DocumentLoader
void clearRedirectChain();
void appendRedirect(const KURL&);
- ContentSecurityPolicy* releaseContentSecurityPolicy() {
- return m_contentSecurityPolicy.release();
- }
-
ClientHintsPreferences& clientHintsPreferences() {
return m_clientHintsPreferences;
}
@@ -216,12 +212,19 @@ class CORE_EXPORT DocumentLoader
Vector<KURL> m_redirectChain;
private:
- static DocumentWriter* createWriterFor(const DocumentInit&,
- const AtomicString& mimeType,
- const AtomicString& encoding,
- bool dispatchWindowObjectAvailable,
- ParserSynchronizationPolicy,
- const KURL& overridingURL = KURL());
+ // installNewDocument() does the work of creating a Document and
+ // DocumentWriter, as well as creating a new LocalDOMWindow if needed. It also
+ // initalizes a bunch of state on the Document (e.g., the state based on
+ // response headers).
+ enum class InstallNewDocumentReason { kNavigation, kJavascriptURL };
+ void installNewDocument(const DocumentInit&,
+ const AtomicString& mimeType,
+ const AtomicString& encoding,
+ InstallNewDocumentReason,
+ ParserSynchronizationPolicy,
+ const KURL& overridingURL);
+ void didInstallNewDocument(Document*);
+ void didCommitNavigation();
void ensureWriter(const AtomicString& mimeType,
const KURL& overridingURL = KURL());
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698