Clean up DocumentWriter creation's FrameLoader interaction

third_party/WebKit/Source/core/loader/DocumentLoader.h

Index: third_party/WebKit/Source/core/loader/DocumentLoader.h
diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.h b/third_party/WebKit/Source/core/loader/DocumentLoader.h
index a30b783bd8ce33ef96762f26a80212e11ca57204..9f7111abdf9cfba29d340d30611b380e7a616ddd 100644
--- a/third_party/WebKit/Source/core/loader/DocumentLoader.h
+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.h
@@ -166,10 +166,6 @@ class CORE_EXPORT DocumentLoader
   void clearRedirectChain();
   void appendRedirect(const KURL&);
 
-  ContentSecurityPolicy* releaseContentSecurityPolicy() {
-    return m_contentSecurityPolicy.release();
-  }
-
   ClientHintsPreferences& clientHintsPreferences() {
     return m_clientHintsPreferences;
   }
@@ -216,12 +212,15 @@ class CORE_EXPORT DocumentLoader
   Vector<KURL> m_redirectChain;
 
  private:
-  static DocumentWriter* createWriterFor(const DocumentInit&,

[Nate Chapin, 2017/03/17 23:33:18]

This method (1) does enough DocumentLoader-related stuff that I think non-static
is better, (2) does more than creating a DocumentWriter, renamed accordingly.

[Mike West, 2017/03/21 09:39:30]

Maybe add a comment explaining the scope?

[Nate Chapin, 2017/03/21 19:26:58]

Done.

-                                         const AtomicString& mimeType,
-                                         const AtomicString& encoding,
-                                         bool dispatchWindowObjectAvailable,
-                                         ParserSynchronizationPolicy,
-                                         const KURL& overridingURL = KURL());
+  enum class InstallNewDocumentReason { kNavigation, kJavascriptURL };
+  void installNewDocument(const DocumentInit&,
+                          const AtomicString& mimeType,
+                          const AtomicString& encoding,
+                          InstallNewDocumentReason,
+                          ParserSynchronizationPolicy,
+                          const KURL& overridingURL);
+  void didInstallNewDocument(Document*);
+  void didCommitNavigation();
 
   void ensureWriter(const AtomicString& mimeType,
                     const KURL& overridingURL = KURL());