Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 275183002: patch from issue 218843002 (Closed)

Created:
6 years, 7 months ago by luken
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tdanderson+views_chromium.org, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, benquan, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, kalyank, ben+views_chromium.org, James Su, Ilya Sherman, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

patch from issue 218843002 This is another attempt to merge the R*Tree bounding boxes CL, after the first one got kicked back by ASAN/LSAN bots. The leak has been repaired. BUG=353867 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269883

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -100 lines) Patch
M ash/system/user/user_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/top_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 6 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/views/speech_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/message_center/views/bounded_label.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/message_center/views/bounded_label.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M ui/views/controls/menu/submenu_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/separator.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/separator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/views/cull_set.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ui/views/cull_set.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/views/view.h View 7 chunks +38 lines, -3 lines 0 comments Download
M ui/views/view.cc View 13 chunks +169 lines, -28 lines 0 comments Download
M ui/views/view_unittest.cc View 3 chunks +242 lines, -2 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
luken
The views_unittests code tests LSAN/ASAN clean on my Linux workstation. Can we please attempt another ...
6 years, 7 months ago (2014-05-09 19:24:41 UTC) #1
sky
As long as this is the same as the last patch, LGTM
6 years, 7 months ago (2014-05-09 20:46:43 UTC) #2
luken
The CQ bit was checked by luken@chromium.org
6 years, 7 months ago (2014-05-12 18:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luken@chromium.org/275183002/20001
6 years, 7 months ago (2014-05-12 18:04:51 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 21:47:33 UTC) #5
Message was sent while issue was closed. 
Change committed as 269883

Powered by Google App Engine
This is Rietveld 408576698