Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: net/http/transport_security_persister.h

Issue 2751803002: Serialize and deserialize dynamic Expect-CT state (Closed)
Patch Set: add test for LoadEntries clearing Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/transport_security_persister.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_persister.h
diff --git a/net/http/transport_security_persister.h b/net/http/transport_security_persister.h
index d4e1e36a2c0966181f940ea52ab38027c7a14a47..d2fad85749103616b5f71c9c92983511774b3628 100644
--- a/net/http/transport_security_persister.h
+++ b/net/http/transport_security_persister.h
@@ -44,7 +44,6 @@
#include "net/http/transport_security_state.h"
namespace base {
-class DictionaryValue;
class SequencedTaskRunner;
}
@@ -72,7 +71,7 @@ class NET_EXPORT TransportSecurityPersister
// ImportantFileWriter::DataSerializer:
//
// Serializes |transport_security_state_| into |*output|. Returns true if
- // all STS and PKP states were serialized correctly.
+ // all STS, PKP, and Expect_CT states were serialized correctly.
//
// The serialization format is JSON; the JSON represents a dictionary of
// host:DomainState pairs (host is a string). The DomainState contains
@@ -94,6 +93,15 @@ class NET_EXPORT TransportSecurityPersister
// "bad_static_spki_hashes": list of strings
// legacy key synonym "bad_preloaded_spki_hashes"
// "dynamic_spki_hashes": list of strings
+ // "dynamic_spki_hashes_expiry": double
+ // "report-uri": string
+ // "sts_observed": double
+ // "pkp_observed": double
+ // "expect_ct": dictionary with keys:
+ // "expect_ct_expiry": double
+ // "expect_ct_observed": double
+ // "expect_ct_enforce": true|false
+ // "expect_ct_report_uri": string
//
// The JSON dictionary keys are strings containing
// Base64(SHA256(TransportSecurityState::CanonicalizeHost(domain))).
@@ -119,14 +127,6 @@ class NET_EXPORT TransportSecurityPersister
bool* dirty,
TransportSecurityState* state);
- // Populates |host| with default values for the STS and PKP states.
- // These default values represent "null" states and are only useful to keep
- // the entries in the resulting JSON consistent. The deserializer will ignore
- // "null" states.
- // TODO(davidben): This can be removed when the STS and PKP states are stored
- // independently on disk. https://crbug.com/470295
- void PopulateEntryWithDefaults(base::DictionaryValue* host);
-
void CompleteLoad(const std::string& state);
TransportSecurityState* transport_security_state_;
« no previous file with comments | « no previous file | net/http/transport_security_persister.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698