Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 27518003: [PDF] Add unpremultiply support and a GM. (Closed)

Created:
7 years, 2 months ago by vandebo (ex-Chrome)
Modified:
7 years, 2 months ago
Reviewers:
edisonn
CC:
skia-review_googlegroups.com, bungeman-skia, caryclark
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

[PDF] Add unpremultiply support and a GM. This is a resubmit of https://codereview.chromium.org/22831039 which was reverted because it causes issues on Windows. BUG=chromium:175548 R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=11857

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 4

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -2 lines) Patch
A gm/bitmappremul.cpp View 1 chunk +131 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 1 2 2 chunks +161 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vandebo (ex-Chrome)
I think a memory issue was fixed after this was reverted, so we should give ...
7 years, 2 months ago (2013-10-16 16:27:38 UTC) #1
vandebo (ex-Chrome)
Fixed the upload issue if you've already looked at this.
7 years, 2 months ago (2013-10-17 18:58:08 UTC) #2
edisonn
7 years, 2 months ago (2013-10-17 19:42:56 UTC) #3
edisonn
lgtm https://codereview.chromium.org/27518003/diff/8001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/27518003/diff/8001/src/pdf/SkPDFImage.cpp#newcode353 src/pdf/SkPDFImage.cpp:353: remove_alpha_argb8888(SkPixel4444ToPixel32(pmColor))); would not be more optimum to & ...
7 years, 2 months ago (2013-10-17 19:52:39 UTC) #4
vandebo (ex-Chrome)
Will submit tomorrow am. https://codereview.chromium.org/27518003/diff/8001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/27518003/diff/8001/src/pdf/SkPDFImage.cpp#newcode353 src/pdf/SkPDFImage.cpp:353: remove_alpha_argb8888(SkPixel4444ToPixel32(pmColor))); On 2013/10/17 19:52:39, edisonn ...
7 years, 2 months ago (2013-10-17 21:46:42 UTC) #5
vandebo (ex-Chrome)
7 years, 2 months ago (2013-10-18 15:53:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r11857 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698