Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: chrome/browser/ui/android/android_about_app_info.cc

Issue 2751773002: Add Google Play services info to chrome://version (Closed)
Patch Set: add the string only in android Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/android_about_app_info.cc
diff --git a/chrome/browser/ui/android/android_about_app_info.cc b/chrome/browser/ui/android/android_about_app_info.cc
index 417e703b0ba68dfb2428470c953d47bc3e5080c6..ba3808ce245dc7d31977d41a5a4a8a5441322f72 100644
--- a/chrome/browser/ui/android/android_about_app_info.cc
+++ b/chrome/browser/ui/android/android_about_app_info.cc
@@ -4,12 +4,23 @@
#include "chrome/browser/ui/android/android_about_app_info.h"
+#include <jni.h>
#include <stdint.h>
#include <string>
+#include "base/android/jni_android.h"
+#include "base/android/jni_string.h"
#include "base/strings/stringprintf.h"
#include "base/sys_info.h"
+#include "jni/ChromeVersionInfo_jni.h"
+
+std::string AndroidAboutAppInfo::GetGmsInfo() {
+ JNIEnv* env = base::android::AttachCurrentThread();
+ const base::android::ScopedJavaLocalRef<jstring> info =
+ Java_ChromeVersionInfo_getGmsInfo(env);
+ return base::android::ConvertJavaStringToUTF8(env, info);
+}
std::string AndroidAboutAppInfo::GetOsInfo() {
std::string android_info_str;

Powered by Google App Engine
This is Rietveld 408576698