Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 275173002: cc: Add a checkerboard trace event instant to picture layer impl. (Closed)

Created:
6 years, 7 months ago by vmpstr
Modified:
6 years, 7 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Add a checkerboard trace event instant to picture layer impl. This is a small patch that adds a trace event instant whenever we draw checkerboards. This is useful for debugging or figuring out exactly when we checkerboarded. R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269631

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vmpstr
Please take a look.
6 years, 7 months ago (2014-05-09 19:11:06 UTC) #1
danakj
https://codereview.chromium.org/275173002/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/275173002/diff/1/cc/layers/picture_layer_impl.cc#newcode254 cc/layers/picture_layer_impl.cc:254: TRACE_EVENT_INSTANT0("cc", This could potentially happen an awful lot during ...
6 years, 7 months ago (2014-05-09 19:20:14 UTC) #2
vmpstr
PTAL https://codereview.chromium.org/275173002/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/275173002/diff/1/cc/layers/picture_layer_impl.cc#newcode254 cc/layers/picture_layer_impl.cc:254: TRACE_EVENT_INSTANT0("cc", On 2014/05/09 19:20:14, danakj wrote: > This ...
6 years, 7 months ago (2014-05-09 19:29:03 UTC) #3
danakj
LGTM
6 years, 7 months ago (2014-05-09 19:34:40 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-09 19:41:24 UTC) #5
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 7 months ago (2014-05-09 19:42:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/275173002/20001
6 years, 7 months ago (2014-05-09 19:45:21 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 20:39:44 UTC) #8
Message was sent while issue was closed.
Change committed as 269631

Powered by Google App Engine
This is Rietveld 408576698