Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: src/parsing/scanner.cc

Issue 2751693002: [wasm][asm.js] Adding custom asm.js lexer. (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/scanner.cc
diff --git a/src/parsing/scanner.cc b/src/parsing/scanner.cc
index e92b97454adcda0dbe8163547fcdc80b58eba099..2ff66be6715d50d3c58d2fe55b49b7fd40f2c7eb 100644
--- a/src/parsing/scanner.cc
+++ b/src/parsing/scanner.cc
@@ -1161,10 +1161,22 @@ Token::Value Scanner::ScanTemplateStart() {
Token::Value Scanner::ScanTemplateContinuation() {
DCHECK_EQ(next_.token, Token::RBRACE);
- next_.location.beg_pos = source_pos() - 1; // We already consumed }
+ next_.location.beg_pos = source_pos() - 2; // We already consumed }
vogelheim 2017/03/16 12:46:48 wut? I don't understand this change.
bradn 2017/03/16 17:03:15 Mismatch on my two branches, removed.
return ScanTemplateSpan();
}
+Handle<String> Scanner::SourceUrl(Isolate* isolate) const {
vogelheim 2017/03/16 12:46:48 Is this because we previously relied on v8::intern
bradn 2017/03/16 17:03:15 Yep.
+ Handle<String> tmp;
+ if (source_url_.length() > 0) tmp = source_url_.Internalize(isolate);
+ return tmp;
+}
+
+Handle<String> Scanner::SourceMappingUrl(Isolate* isolate) const {
+ Handle<String> tmp;
+ if (source_mapping_url_.length() > 0)
+ tmp = source_mapping_url_.Internalize(isolate);
+ return tmp;
+}
void Scanner::ScanDecimalDigits() {
while (IsDecimalDigit(c0_))

Powered by Google App Engine
This is Rietveld 408576698