ios/chrome/browser/ui/content_suggestions/content_suggestions_header_item.h - Issue 2751653008: Add header for the Content Suggestions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_header_item.h

Issue 2751653008: Add header for the Content Suggestions (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_HEADER_ITE M_H_

	6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_HEADER_ITE M_H_

	7

	8 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h "

	9 #import "ios/chrome/browser/ui/content_suggestions/content_suggestion_identifier .h"

	10

	11 @interface ContentSuggestionsHeaderItem
	lpromero 2017/03/16 16:43:21 Can you add a comment? I am not a fan of subclassi Can you add a comment? I am not a fan of subclassing CollectionViewTextItem. Where do you use the suggestionIdentifier you are strapping to this item? Since it is a header and not a suggestion, how come it even can have a suggestion identifier? gambard 2017/03/17 09:33:39 Done. Show quoted text On 2017/03/16 16:43:21, lpromero wrote: > Can you add a comment? I am not a fan of subclassing CollectionViewTextItem. > Where do you use the suggestionIdentifier you are strapping to this item? Since > it is a header and not a suggestion, how come it even can have a suggestion > identifier? Done.
	12 : CollectionViewTextItem<ContentSuggestionIdentification>

	13

	14 @end

	15

	16 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_HEADER_ ITEM_H_

OLD	NEW