third_party/WebKit/Source/core/style/CounterDirectives.h - Issue 2751653003: Replace ASSERT and ASSERT_NOT_REACHED in core/style/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/CounterDirectives.h

Issue 2751653003: Replace ASSERT and ASSERT_NOT_REACHED in core/style/ (Closed)

Patch Set: Replace ASSERT and ASSERT_NOT_REACHED in core/style/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/CounterDirectives.h

diff --git a/third_party/WebKit/Source/core/style/CounterDirectives.h b/third_party/WebKit/Source/core/style/CounterDirectives.h

index 1529b955ee7aaa0b991c2ce80f6809df6d3f7627..631d9eb8833ca8b93a6a4cc990c5a824a577bd13 100644

--- a/third_party/WebKit/Source/core/style/CounterDirectives.h

+++ b/third_party/WebKit/Source/core/style/CounterDirectives.h

@@ -81,8 +81,8 @@ class CounterDirectives {

bool isDefined() const { return isReset() || isIncrement(); }

int combinedValue() const {

- ASSERT(m_isResetSet || !m_resetValue);

- ASSERT(m_isIncrementSet || !m_incrementValue);

+ DCHECK(m_isResetSet || !m_resetValue);

+ DCHECK(m_isIncrementSet || !m_incrementValue);

// FIXME: Shouldn't allow overflow here.

return m_resetValue + m_incrementValue;

}