Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java

Issue 2751583002: 🏡 Show correct BottomSheetContent toolbar when contents swapped (Closed)
Patch Set: Remove duplicate "and" Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
index bd9fdd10d981174aa8ab325ebba362066380a7c7..29153983d4638bcc481789bbd5779f81334e63ef 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
@@ -14,6 +14,7 @@ import android.support.v4.view.GravityCompat;
import android.support.v4.widget.DrawerLayout;
import android.support.v4.widget.DrawerLayout.DrawerListener;
import android.support.v7.widget.RecyclerView;
+import android.support.v7.widget.Toolbar;
import android.support.v7.widget.Toolbar.OnMenuItemClickListener;
import android.view.Gravity;
import android.view.LayoutInflater;
@@ -179,10 +180,19 @@ public class DownloadManagerUi implements OnMenuItemClickListener, SearchDelegat
private ViewGroup mMainView;
private DownloadManagerToolbar mToolbar;
private SelectableListLayout<DownloadHistoryItemWrapper> mSelectableListLayout;
+ private boolean mIsSeparateActivity;
- @SuppressWarnings("unchecked") // mSelectableListLayout
- public DownloadManagerUi(
- Activity activity, boolean isOffTheRecord, ComponentName parentComponent) {
+ /**
+ * Constructs a new DownloadManagerUi.
+ * @param activity The {@link Activity} associated with the download manager.
+ * @param isOffTheRecord Whether an off-the-record tab is currently being displayed.
+ * @param parentComponent The {@link ComponentName} of the parent activity.
+ * @param isSeparateActivity Whether the download manager UI will be shown in a separate
+ * activity than the main Chrome activity.
+ */
+ @SuppressWarnings("unchecked") // mSelectableListLayout
+ public DownloadManagerUi(Activity activity, boolean isOffTheRecord,
+ ComponentName parentComponent, boolean isSeparateActivity) {
mActivity = activity;
mBackendProvider =
sProviderForTests == null ? new DownloadBackendProvider() : sProviderForTests;
@@ -233,6 +243,9 @@ public class DownloadManagerUi implements OnMenuItemClickListener, SearchDelegat
mFilterView.setOnItemClickListener(mFilterAdapter);
mUndoDeletionSnackbarController = new UndoDeletionSnackbarController();
+
+ mIsSeparateActivity = isSeparateActivity;
+ if (!mIsSeparateActivity) mToolbar.removeCloseButton();
}
/**
@@ -288,10 +301,10 @@ public class DownloadManagerUi implements OnMenuItemClickListener, SearchDelegat
}
/**
- * See {@link SelectableListLayout#detachContentView()}.
+ * See {@link SelectableListLayout#detachToolbarView()}.
*/
- public View detachContentView() {
- return mSelectableListLayout.detachContentView();
+ public Toolbar detachToolbarView() {
+ return mSelectableListLayout.detachToolbarView();
}
/**
@@ -311,7 +324,7 @@ public class DownloadManagerUi implements OnMenuItemClickListener, SearchDelegat
@Override
public boolean onMenuItemClick(MenuItem item) {
- if (item.getItemId() == R.id.close_menu_id && !DeviceFormFactor.isTablet(mActivity)) {
+ if (item.getItemId() == R.id.close_menu_id && mIsSeparateActivity) {
mActivity.finish();
return true;
} else if (item.getItemId() == R.id.selection_mode_delete_menu_id) {

Powered by Google App Engine
This is Rietveld 408576698