chrome/android/java/res/values-v17/styles.xml - Issue 2751583002: 🏡 Show correct BottomSheetContent toolbar when contents swapped

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2751583002: 🏡 Show correct BottomSheetContent toolbar when contents swapped (Closed)

Patch Set: Changes from mdjones@ review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/bottom_control_container.xml ('K') | « chrome/android/java/res/layout/bottom_control_container.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources xmlns:tools="http://schemas.android.com/tools">	6 <resources xmlns:tools="http://schemas.android.com/tools">

7 <!-- Q: Why put style resources under values-v17/ ?	7 <!-- Q: Why put style resources under values-v17/ ?

8 A: Problem:	8 A: Problem:

9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.	9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.

10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert	10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert

(...skipping 656 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
667 <item name="android:singleLine">true</item>	667 <item name="android:singleLine">true</item>

668 </style>	668 </style>

669 <style name="DownloadIconView">	669 <style name="DownloadIconView">

670 <item name="android:layout_width">@dimen/downloads_item_icon_size</item>	670 <item name="android:layout_width">@dimen/downloads_item_icon_size</item>

671 <item name="android:layout_height">@dimen/downloads_item_icon_size</item >	671 <item name="android:layout_height">@dimen/downloads_item_icon_size</item >

672 <item name="android:layout_marginEnd">16dp</item>	672 <item name="android:layout_marginEnd">16dp</item>

673 <item name="android:contentDescription">@null</item>	673 <item name="android:contentDescription">@null</item>

674 <item name="android:scaleType">center</item>	674 <item name="android:scaleType">center</item>

675 <item name="android:background">@color/light_active_color</item>	675 <item name="android:background">@color/light_active_color</item>

676 </style>	676 </style>

	677
	gone 2017/03/15 17:21:15 no newline no newline Theresa 2017/03/16 18:15:16 I added a "Miscellaneous" comment above this style Show quoted text On 2017/03/15 17:21:15, dfalcantara (load balance plz) wrote: > no newline I added a "Miscellaneous" comment above this style rule. All of the above styles are part of the <!-- Download Home --> block.
	678 <style name="BottomSheetContentTitle" parent="TextAppearance.Widget.AppCompa t.Toolbar.Title">

	679 <item name="android:textSize">20sp</item>

	680 </style>

677 </resources>	681 </resources>

OLD	NEW