🏡 Show correct BottomSheetContent toolbar when contents swapped

chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.toolbar;
 
 import android.content.Context;
+import android.support.v7.widget.Toolbar;
 import android.util.AttributeSet;
 import android.view.ViewGroup;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.widget.BottomSheet;
 import org.chromium.chrome.browser.widget.BottomSheetObserver;
 
 /**
  * Phone specific toolbar that exists at the bottom of the screen.
  */
 public class BottomToolbarPhone extends ToolbarPhone implements BottomSheetObserver {
     /** A handle to the bottom sheet. */
     private BottomSheet mBottomSheet;
 
     /**
      * Whether the end toolbar buttons should be hidden regardless of whether the URL bar is
      * focused.
      */
     private boolean mShouldHideEndToolbarButtons;
 
     /**
      * This tracks the height fraction of the bottom bar to determine if it is moving up or down.
      */
     private float mLastHeightFraction;
 
     /**
+     * Sets the height and title text appearance of the provided toolbar so that its style is
+     * consistent with BottomToolbarPhone.
+     * @param toolbar The toolbar to style.
+     */
+    public static void setToolbarStyle(Toolbar toolbar) {
+        // Android's Toolbar class typically changes its height based on device orientation.
+        // BottomToolbarPhone has a fixed height. Update |toolbar| to match.
+        toolbar.getLayoutParams().height =
+                toolbar.getResources().getDimensionPixelOffset(R.dimen.toolbar_height_no_shadow);

[Theresa, 2017/03/14 16:29:43]

This will also change to bottom_control_container_height after the pull handle
CL lands.

[mdjones, 2017/03/14 20:08:36]

I'm going to try to land a patch that adds getHeight to toolbar. If I get that
in, you shouldn't need to specify this.

+
+        // Android Toolbar action buttons are aligned based on the minimum height.
+        toolbar.setMinimumHeight(
+                toolbar.getResources().getDimensionPixelOffset(R.dimen.toolbar_height_no_shadow));

[Theresa, 2017/03/14 16:29:43]

The toolbar will get bottom_toolbar_top_margin as extra top padding to push it
below the pull handle. The minimum height will also be adjusted to
bottom_control_container_height - bottom_toolbar_top_margin.

+
+        toolbar.setTitleTextAppearance(toolbar.getContext(), R.style.BottomSheetContentTitle);
+        toolbar.requestLayout();
+    }
+
+    /**
      * Constructs a BottomToolbarPhone object.
      * @param context The Context in which this View object is created.
      * @param attrs The AttributeSet that was specified with this View.
      */
     public BottomToolbarPhone(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
 
     @Override
     protected int getProgressBarTopMargin() {
@@ skipping 71 matching lines @@
         boolean isMovingDown = heightFraction < mLastHeightFraction;
         mLastHeightFraction = heightFraction;
 
         // The only time the omnibox should have focus is when the sheet is fully expanded. Any
         // movement of the sheet should unfocus it.
         if (isMovingDown && getLocationBar().isUrlBarFocused()) {
             getLocationBar().setUrlBarFocus(false);
         }
     }
 }