Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3094)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm

Issue 2751573002: [Mac] Refactor bookmark bar controller (Closed)
Patch Set: Factor layout tests to helper, address CL comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm
index 578b545e486ec08c978908bde6ba99fd6af515bb..389ea7b4cee4cb7d7d4d3d39419bce771884bda1 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm
@@ -113,10 +113,11 @@ TEST_F(BookmarkBarBridgeTest, TestRedirect) {
bridge->BookmarkNodeFaviconChanged(NULL, NULL);
bridge->BookmarkNodeChildrenReordered(NULL, NULL);
bridge->BookmarkNodeRemoved(NULL, NULL, 0, NULL, std::set<GURL>());
- // 7 calls above plus an initial Loaded() in init routine makes 8.
- EXPECT_EQ(controller.get()->called_selectors_.size(), 8U);
+ // 7 calls above plus two Loaded() in init routing makes 9.
+ EXPECT_EQ(controller.get()->called_selectors_.size(), 9U);
std::vector<SEL> expected_selectors = {
@selector(loaded:), // initial from init
+ @selector(loaded:), // initial from init
@selector(loaded:),
@selector(nodeMoved:oldParent:oldIndex:newParent:newIndex:),
@selector(nodeAdded:parent:index:),

Powered by Google App Engine
This is Rietveld 408576698