Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h

Issue 2751573002: [Mac] Refactor bookmark bar controller (Closed)
Patch Set: Restore unused button pool Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_VIEW_COCOA_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_VIEW_COCOA_H_
6 #define CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_VIEW_COCOA_H_ 6 #define CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_VIEW_COCOA_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include "base/mac/scoped_nsobject.h" 10 #include "base/mac/scoped_nsobject.h"
11 11
12 @class BookmarkBarController; 12 @class BookmarkBarController;
13 13
14 // A simple custom NSView for the bookmark bar used to prevent clicking and 14 // A simple custom NSView for the bookmark bar used to prevent clicking and
15 // dragging from moving the browser window. 15 // dragging from moving the browser window.
16 @interface BookmarkBarView : NSView { 16 @interface BookmarkBarView : NSView {
17 @private 17 @private
18 BOOL dropIndicatorShown_; 18 BOOL dropIndicatorShown_;
19 CGFloat dropIndicatorPosition_; // x position 19 CGFloat dropIndicatorPosition_; // x position
20 20
21 BookmarkBarController* controller_; 21 BookmarkBarController* controller_;
22 base::scoped_nsobject<NSTextField> noItemTextfield_; 22 base::scoped_nsobject<NSTextField> noItemTextField_;
Elly Fong-Jones 2017/03/23 15:40:22 thank you for fixing this
23 base::scoped_nsobject<NSButton> importBookmarksButton_; 23 base::scoped_nsobject<NSButton> importBookmarksButton_;
24 base::scoped_nsobject<NSView> noItemContainer_;
25 } 24 }
26 - (NSTextField*)noItemTextfield; 25 - (NSTextField*)noItemTextField;
27 - (NSButton*)importBookmarksButton; 26 - (NSButton*)importBookmarksButton;
28 - (NSView*)noItemContainer;
29 27
30 - (instancetype)initWithController:(BookmarkBarController*)controller 28 - (instancetype)initWithController:(BookmarkBarController*)controller
31 frame:(NSRect)frame; 29 frame:(NSRect)frame;
32 - (void)registerForNotificationsAndDraggedTypes; 30 - (void)registerForNotificationsAndDraggedTypes;
33 31
34 // Exposed so the controller can nil itself out. 32 // Exposed so the controller can nil itself out.
35 @property(nonatomic, assign) BookmarkBarController* controller; 33 @property(nonatomic, assign) BookmarkBarController* controller;
36 @end 34 @end
37 35
38 @interface BookmarkBarView() // TestingOrInternalAPI 36 @interface BookmarkBarView() // TestingOrInternalAPI
39 @property(nonatomic, readonly) BOOL dropIndicatorShown; 37 @property(nonatomic, readonly) BOOL dropIndicatorShown;
40 @property(nonatomic, readonly) CGFloat dropIndicatorPosition; 38 @property(nonatomic, readonly) CGFloat dropIndicatorPosition;
41 @end 39 @end
42 40
43 #endif // CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_VIEW_COCOA_H_ 41 #endif // CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_VIEW_COCOA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698