Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 2751543003: VM: Simplify lowering of is-tests. (Closed)
Patch Set: fix dbc build Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_mips.cc
diff --git a/runtime/vm/flow_graph_compiler_mips.cc b/runtime/vm/flow_graph_compiler_mips.cc
index 88998fe385de42e62c8981584338680271d8a626..bc76e97a394b6d3378b0041a5555c4a9b9612458 100644
--- a/runtime/vm/flow_graph_compiler_mips.cc
+++ b/runtime/vm/flow_graph_compiler_mips.cc
@@ -544,7 +544,6 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateInlineInstanceof(
void FlowGraphCompiler::GenerateInstanceOf(TokenPosition token_pos,
intptr_t deopt_id,
const AbstractType& type,
- bool negate_result,
LocationSummary* locs) {
ASSERT(type.IsFinalized() && !type.IsMalformed() && !type.IsMalbounded());
ASSERT(!type.IsObjectType() && !type.IsDynamicType());
@@ -594,21 +593,15 @@ void FlowGraphCompiler::GenerateInstanceOf(TokenPosition token_pos,
// instanceof runtime call will be left as the result of the operation.
__ lw(T0, Address(SP, 4 * kWordSize));
__ addiu(SP, SP, Immediate(5 * kWordSize));
- if (negate_result) {
- __ LoadObject(V0, Bool::True());
- __ bne(T0, V0, &done);
- __ LoadObject(V0, Bool::False());
- } else {
- __ mov(V0, T0);
- }
+ __ mov(V0, T0);
__ b(&done);
}
__ Bind(&is_not_instance);
- __ LoadObject(V0, Bool::Get(negate_result));
+ __ LoadObject(V0, Bool::Get(false));
__ b(&done);
__ Bind(&is_instance);
- __ LoadObject(V0, Bool::Get(!negate_result));
+ __ LoadObject(V0, Bool::Get(true));
__ Bind(&done);
// Remove instantiator type arguments (A1).
__ Drop(1);
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698