VM: Simplify lowering of is-tests.

VM: Simplify lowering of is-tests.

Remove special-cases for known types (int, String, num, double, Smi). The generic
lowering into an instance call (_simpleInstanceOf) works just fine for these predefined
types.

Also, remove parameter for negated is-tests. Instead insert explicit negation when.
building the flow graph.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/066123e037b530ae2c073b61601d518ed70d6efa

[Florian Schneider, 2017-03-13 22:50:56]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-03-13 23:46:18]

lgtm

Noting that this means Lars's simpleInstanceOf optimization applies to these
types as well.

[Florian Schneider, 2017-03-13 23:49:06]

Description was changed from

==========
VM: Simplify lowering of is-tests.

Remove special-cases for known types (int, String, num, double, Smi). The
generic
lowering into an instance call (_simpleInstanceOf) works just fine for these
predefined
types.

Also, remove parameter for negated is-tests. Instead insert explicit negation
when.
building the flow graph.
==========

to

==========
VM: Simplify lowering of is-tests.

Remove special-cases for known types (int, String, num, double, Smi). The
generic
lowering into an instance call (_simpleInstanceOf) works just fine for these
predefined
types.

Also, remove parameter for negated is-tests. Instead insert explicit negation
when.
building the flow graph.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/066123e037b530ae2c073b61601d518ed70d6efa
==========

[Florian Schneider, 2017-03-13 23:49:07]

Committed patchset #2 (id:20001) manually as
066123e037b530ae2c073b61601d518ed70d6efa (presubmit successful).

[Vyacheslav Egorov (Google), 2017-03-14 11:32:40]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2017-03-14 11:32:41]

Hi!

I unfortunately had to revert this because vm-kernel-* bots were all completely
broken by this commit.

I think kernel_to_il translation needs an update similar to one done in the
flow_graph_builder.cc

You can repro failues and run tests like this:

$ ./tools/build.py -m release -a x64 runtime_kernel
$ ./tools/test.py -m release -a x64 -c dartk co19 language kernel