third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h - Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h

Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/ (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h b/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h

index 8b9a26571230f9cb5e994acca08dfb49a053424d..d9850c050d3643fbe4a22e4cc62e9cb408d78d49 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h

+++ b/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h

@@ -46,7 +46,7 @@ class DecodedHTMLEntity {

bool isEmpty() const { return !length; }

void append(UChar c) {

- RELEASE_ASSERT(length < kMaxLength);

+ CHECK(length < kMaxLength);

data[length++] = c;

}