Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: src/builtins/builtins-conversion.cc

Issue 2751363002: [csa] Replace remaining old-style GetProperty calls (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-array.cc ('k') | src/builtins/builtins-promise.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-conversion.cc
diff --git a/src/builtins/builtins-conversion.cc b/src/builtins/builtins-conversion.cc
index 37da457d3825880002a6aa78167c41e1b79c9b2a..93a8c2e976a05c846470f0c0a9e5910e3b7f8b08 100644
--- a/src/builtins/builtins-conversion.cc
+++ b/src/builtins/builtins-conversion.cc
@@ -42,10 +42,8 @@ void ConversionBuiltinsAssembler::Generate_NonPrimitiveToPrimitive(
Node* context = Parameter(TypeConversionDescriptor::kContext);
// Lookup the @@toPrimitive property on the {input}.
- Callable callable = CodeFactory::GetProperty(isolate());
- Node* to_primitive_symbol = HeapConstant(factory()->to_primitive_symbol());
Node* exotic_to_prim =
- CallStub(callable, context, input, to_primitive_symbol);
+ GetProperty(context, input, factory()->to_primitive_symbol());
// Check if {exotic_to_prim} is neither null nor undefined.
Label ordinary_to_primitive(this);
@@ -204,9 +202,7 @@ void ConversionBuiltinsAssembler::Generate_OrdinaryToPrimitive(
}
for (Handle<String> name : method_names) {
// Lookup the {name} on the {input}.
- Callable callable = CodeFactory::GetProperty(isolate());
- Node* name_string = HeapConstant(name);
- Node* method = CallStub(callable, context, input, name_string);
+ Node* method = GetProperty(context, input, name);
// Check if the {method} is callable.
Label if_methodiscallable(this),
« no previous file with comments | « src/builtins/builtins-array.cc ('k') | src/builtins/builtins-promise.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698