Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: src/builtins/builtins-array.cc

Issue 2751363002: [csa] Replace remaining old-style GetProperty calls (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-array.cc
diff --git a/src/builtins/builtins-array.cc b/src/builtins/builtins-array.cc
index fd2f2d835e2b8708e01408ee1c26bae56df4d4c8..2916cff23d2cf9b767a0f072156fa6829fc9603f 100644
--- a/src/builtins/builtins-array.cc
+++ b/src/builtins/builtins-array.cc
@@ -454,8 +454,7 @@ class ArrayBuiltinCodeStubAssembler : public CodeStubAssembler {
Goto(&has_length);
Bind(&not_js_array);
Node* len_property =
- CallStub(CodeFactory::GetProperty(isolate()), context, o,
- HeapConstant(isolate()->factory()->length_string()));
+ GetProperty(context, o, isolate()->factory()->length_string());
merged_length.Bind(
CallStub(CodeFactory::ToLength(isolate()), context, len_property));
Goto(&has_length);
@@ -521,8 +520,7 @@ class ArrayBuiltinCodeStubAssembler : public CodeStubAssembler {
// i. Let kValue be Get(O, Pk).
// ii. ReturnIfAbrupt(kValue).
- Node* k_value = CallStub(CodeFactory::GetProperty(isolate()), context,
- o, k.value());
+ Node* k_value = GetProperty(context, o, k.value());
// iii. Let funcResult be Call(callbackfn, T, «kValue, k, O»).
// iv. ReturnIfAbrupt(funcResult).
@@ -2520,9 +2518,8 @@ TF_BUILTIN(ArrayIteratorPrototypeNext, CodeStubAssembler) {
Bind(&if_isnotarray);
{
- Node* length_string = HeapConstant(factory()->length_string());
- Callable get_property = CodeFactory::GetProperty(isolate());
- Node* length = CallStub(get_property, context, array, length_string);
+ Node* length =
+ GetProperty(context, array, factory()->length_string());
Callable to_length = CodeFactory::ToLength(isolate());
var_length.Bind(CallStub(to_length, context, length));
Goto(&done);
@@ -2545,8 +2542,7 @@ TF_BUILTIN(ArrayIteratorPrototypeNext, CodeStubAssembler) {
Bind(&generic_values);
{
- Callable get_property = CodeFactory::GetProperty(isolate());
- var_value.Bind(CallStub(get_property, context, array, index));
+ var_value.Bind(GetProperty(context, array, index));
Goto(&allocate_entry_if_needed);
}
}
« no previous file with comments | « no previous file | src/builtins/builtins-conversion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698