[csa] Replace remaining old-style GetProperty calls

src/builtins/builtins-array.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/code-factory.h"
 #include "src/code-stub-assembler.h"
 #include "src/contexts.h"
@@ skipping 436 matching lines @@
 
     // 3. Let len be ToLength(Get(O, "length")).
     // 4. ReturnIfAbrupt(len).
     Variable merged_length(this, MachineRepresentation::kTagged);
     Label has_length(this, &merged_length), not_js_array(this);
     GotoIf(DoesntHaveInstanceType(o, JS_ARRAY_TYPE), &not_js_array);
     merged_length.Bind(LoadJSArrayLength(o));
     Goto(&has_length);
     Bind(&not_js_array);
     Node* len_property =
-        CallStub(CodeFactory::GetProperty(isolate()), context, o,
-                 HeapConstant(isolate()->factory()->length_string()));
+        GetProperty(context, o, isolate()->factory()->length_string());
     merged_length.Bind(
         CallStub(CodeFactory::ToLength(isolate()), context, len_property));
     Goto(&has_length);
     Bind(&has_length);
     Node* len = merged_length.value();
 
     // 5. If IsCallable(callbackfn) is false, throw a TypeError exception.
     Label type_exception(this, Label::kDeferred);
     Label done(this);
     GotoIf(TaggedIsSmi(callbackfn), &type_exception);
@@ skipping 45 matching lines @@
         // b. Let kPresent be HasProperty(O, Pk).
         // c. ReturnIfAbrupt(kPresent).
         Node* k_present =
             CallStub(CodeFactory::HasProperty(isolate()), context, p_k, o);
 
         // d. If kPresent is true, then
         GotoIf(WordNotEqual(k_present, TrueConstant()), &done_element);
 
         // i. Let kValue be Get(O, Pk).
         // ii. ReturnIfAbrupt(kValue).
-        Node* k_value = CallStub(CodeFactory::GetProperty(isolate()), context,
-                                 o, k.value());
+        Node* k_value = GetProperty(context, o, k.value());
 
         // iii. Let funcResult be Call(callbackfn, T, «kValue, k, O»).
         // iv. ReturnIfAbrupt(funcResult).
         Node* result = CallJS(CodeFactory::Call(isolate()), context, callbackfn,
                               this_arg, k_value, k.value(), o);
 
         processor(a, p_k, result);
         Goto(&done_element);
         Bind(&done_element);
 
@@ skipping 1977 matching lines @@
             Node* invalid =
                 SmiConstant(Smi::FromInt(Isolate::kProtectorInvalid));
             Node* cell = LoadRoot(Heap::kFastArrayIterationProtectorRootIndex);
             StoreObjectFieldNoWriteBarrier(cell, Cell::kValueOffset, invalid);
             Goto(&done);
           }
         }
 
         Bind(&if_isnotarray);
         {
-          Node* length_string = HeapConstant(factory()->length_string());
-          Callable get_property = CodeFactory::GetProperty(isolate());
-          Node* length = CallStub(get_property, context, array, length_string);
+          Node* length =
+              GetProperty(context, array, factory()->length_string());
           Callable to_length = CodeFactory::ToLength(isolate());
           var_length.Bind(CallStub(to_length, context, length));
           Goto(&done);
         }
 
         Bind(&done);
         length = var_length.value();
       }
 
       GotoUnlessNumberLessThan(index, length, &set_done);
 
       StoreObjectField(iterator, JSArrayIterator::kNextIndexOffset,
                        NumberInc(index));
       var_done.Bind(FalseConstant());
 
       Branch(
           Uint32LessThanOrEqual(
               instance_type, Int32Constant(JS_GENERIC_ARRAY_KEY_ITERATOR_TYPE)),
           &allocate_key_result, &generic_values);
 
       Bind(&generic_values);
       {
-        Callable get_property = CodeFactory::GetProperty(isolate());
-        var_value.Bind(CallStub(get_property, context, array, index));
+        var_value.Bind(GetProperty(context, array, index));
         Goto(&allocate_entry_if_needed);
       }
     }
 
     Bind(&if_istypedarray);
     {
       Node* buffer = LoadObjectField(array, JSTypedArray::kBufferOffset);
       GotoIf(IsDetachedBuffer(buffer), &if_isdetached);
 
       Node* length = LoadObjectField(array, JSTypedArray::kLengthOffset);
@@ skipping 183 matching lines @@
   {
     Node* message = SmiConstant(MessageTemplate::kDetachedOperation);
     CallRuntime(Runtime::kThrowTypeError, context, message,
                 HeapConstant(operation));
     Unreachable();
   }
 }
 
 }  // namespace internal
 }  // namespace v8