Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: chrome/browser/installable/installable_logging.cc

Issue 2751343002: Adds a basic offline check to InstallableManager. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/installable/installable_logging.h ('k') | chrome/browser/installable/installable_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/installable/installable_logging.cc
diff --git a/chrome/browser/installable/installable_logging.cc b/chrome/browser/installable/installable_logging.cc
index 6f0cdc4234663866ee29a6e93d5e3edd60658f70..926dd2a3d6beadadfe3fbd6c43e79086faa210f4 100644
--- a/chrome/browser/installable/installable_logging.cc
+++ b/chrome/browser/installable/installable_logging.cc
@@ -64,7 +64,7 @@ static const char kUrlNotSupportedForWebApkMessage[] =
"a URL in the web manifest contains a username, password, or port";
static const char kInIncognitoMessage[] =
"the page is loaded in an incognito window";
-
+static const char kNotOfflineCapable[] = "the page does not work offline";
} // namespace
void LogErrorToConsole(content::WebContents* web_contents,
@@ -151,6 +151,9 @@ void LogErrorToConsole(content::WebContents* web_contents,
case IN_INCOGNITO:
pattern = kInIncognitoMessage;
break;
+ case NOT_OFFLINE_CAPABLE:
+ pattern = kNotOfflineCapable;
+ break;
}
if (!pattern)
« no previous file with comments | « chrome/browser/installable/installable_logging.h ('k') | chrome/browser/installable/installable_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698