Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: chrome/browser/installable/installable_logging.h

Issue 2751343002: Adds a basic offline check to InstallableManager. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_logging.h
diff --git a/chrome/browser/installable/installable_logging.h b/chrome/browser/installable/installable_logging.h
index 369afc5fbd4f0010941b7c0e2b3fdab3925ba36a..910121b66ea12d99d1be4f9ce878bcc010c358db 100644
--- a/chrome/browser/installable/installable_logging.h
+++ b/chrome/browser/installable/installable_logging.h
@@ -46,6 +46,7 @@ enum InstallableStatusCode {
FAILED_TO_CREATE_BANNER,
URL_NOT_SUPPORTED_FOR_WEBAPK,
IN_INCOGNITO,
+ NO_SERVICE_WORKER_FETCH_HANDLER,
dominickn 2017/03/16 06:21:56 Nit: SITE_NOT_OFFLINE_CAPABLE ? I think it's best
piotrs 2017/03/17 02:21:37 Done.
MAX_ERROR_CODE,
dominickn 2017/03/16 06:21:56 You'll need to edit the (giant giant) tools/metric
piotrs 2017/03/17 02:21:37 Thanks, missed that :) Done.
};
« no previous file with comments | « no previous file | chrome/browser/installable/installable_logging.cc » ('j') | chrome/browser/installable/installable_logging.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698