Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(263)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/banners/no_sw_fetch_handler_test_page.html
Issue
2751343002
:
Adds a basic offline check to InstallableManager. (Closed)
Patch Set: Rebase
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/installable/installable_logging.h
chrome/browser/installable/installable_logging.cc
chrome/browser/installable/installable_manager.h
chrome/browser/installable/installable_manager.cc
chrome/browser/installable/installable_manager_browsertest.cc
chrome/test/data/banners/no_sw_fetch_handler_test_page.html
chrome/test/data/banners/service_worker.js
chrome/test/data/banners/service_worker_no_fetch_handler.js
content/browser/service_worker/service_worker_context_core.cc
content/browser/service_worker/service_worker_context_wrapper.h
content/browser/service_worker/service_worker_context_wrapper.cc
content/public/browser/service_worker_context.h
tools/metrics/histograms/histograms.xml
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/installable/installable_manager_browsertest.cc
('k') |
chrome/test/data/banners/service_worker.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<head>
3
<link rel="manifest" href="manifest.json" />
4
<script>
5
navigator.serviceWorker.register('service_worker_no_fetch_handler.js');
6
</script>
7
</head>
8
<body>
9
Page with a service worker missing a fetch handler.
10
</body>
11
</html>
OLD
NEW
« no previous file with comments
|
« chrome/browser/installable/installable_manager_browsertest.cc
('k') |
chrome/test/data/banners/service_worker.js »
('j') |
no next file with comments »
Issue 2751343002: Adds a basic offline check to InstallableManager. (Closed)
Created 3 years, 9 months ago by piotrs
Modified 3 years, 9 months ago
Reviewers: dominickn, falken, Ilya Sherman, Avi (use Gerrit)
Base URL:
Comments: 40
This is Rietveld
408576698
Chromium Code Reviews
Issue 2751343002:
Adds a basic offline check to InstallableManager. (Closed)
