tools/metrics/histograms/histograms.xml - Issue 2751343002: Adds a basic offline check to InstallableManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2751343002: Adds a basic offline check to InstallableManager. (Closed)

Patch Set: Updating comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 262ca22a17dafdaaf988794fe64d9b93b08ab987..d0940feab8f8444408ab4cf407683b2019218661 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -80606,6 +80606,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

+ <int value="29" label="Service worker not offline capable"/>

falken 2017/03/21 01:53:24 nit: Without knowing the code, I would interpret t

piotrs 2017/03/21 02:12:49 Your understanding as in "a service worker exists"

falken 2017/03/21 02:15:23 Ah, I misread the code, sorry for the noise.

</enum>