Adds a basic offline check to InstallableManager.

chrome/browser/installable/installable_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
 
 #include <map>
 #include <memory>
 #include <tuple>
 #include <utility>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/installable/installable_logging.h"
+#include "content/public/browser/service_worker_context.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 #include "content/public/common/manifest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "url/gurl.h"
 
 // This struct specifies the work to be done by the InstallableManager.
 // Data is cached and fetched in the order specified in this struct. A web app
 // manifest will always be fetched first.
 struct InstallableParams {
@@ skipping 55 matching lines @@
   const GURL& badge_icon_url;
 
   // nullptr if the most appropriate badge icon couldn't be determined or
   // downloaded. The underlying badge icon is owned by the InstallableManager;
   // clients must copy the bitmap if they want to to use it. Since the badge
   // icon is optional, no error code is set if it cannot be fetched, and clients
   // specifying fetch_valid_badge_icon must check that the bitmap exists before
   // using it.
   const SkBitmap* badge_icon;
 
-  // true if the site has a service worker and a viable web app manifest. If
-  // check_installable was true and the site isn't installable, the reason will
-  // be in error_code.
+  // true if the site has a service worker with a fetch handler and a viable web
+  // app manifest. If check_installable was true and the site isn't installable,
+  // the reason will be in error_code.
   const bool is_installable;
 };
 
 using InstallableCallback = base::Callback<void(const InstallableData&)>;
 
 // This class is responsible for fetching the resources required to check and
 // install a site.
 class InstallableManager
     : public content::WebContentsObserver,
       public content::WebContentsUserData<InstallableManager> {
@@ skipping 81 matching lines @@
   void WorkOnTask();
 
   // Data retrieval methods.
   void FetchManifest();
   void OnDidGetManifest(const GURL& manifest_url,
                         const content::Manifest& manifest);
 
   void CheckInstallable();
   bool IsManifestValidForWebApp(const content::Manifest& manifest);
   void CheckServiceWorker();
-  void OnDidCheckHasServiceWorker(bool has_service_worker);
+  void OnDidCheckServiceWorkerStatus(
+      content::ServiceWorkerStatus offline_capability);

[dominickn, 2017/03/16 06:21:56]

Nit: call the variable status

[piotrs, 2017/03/17 02:21:37]

Done.

 
   void CheckAndFetchBestIcon(const IconParams& params);
   void OnIconFetched(
       const GURL icon_url, const IconParams& params, const SkBitmap& bitmap);
 
   // content::WebContentsObserver overrides
   void DidFinishNavigation(content::NavigationHandle* handle) override;
   void WebContentsDestroyed() override;
 
   const GURL& manifest_url() const;
   const content::Manifest& manifest() const;
   bool is_installable() const;
 
   // The list of <params, callback> pairs that have come from a call to GetData.
   std::vector<Task> tasks_;
 
   // Installable properties cached on this object.
   std::unique_ptr<ManifestProperty> manifest_;
   std::unique_ptr<InstallableProperty> installable_;
   std::map<IconParams, IconProperty> icons_;
 
   bool is_active_;
 
   base::WeakPtrFactory<InstallableManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InstallableManager);
 };
 
 #endif  // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_