Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3225)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

Issue 2751333006: Create the base Custom Context Menu Dialog. (Closed)
Patch Set: git rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
index 5069c044e838d547b6c07bf30a6706e468dfc349..c73f44c85d8de2802279d7decb1ae010d6135b33 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java
@@ -4,7 +4,6 @@
package org.chromium.chrome.browser.contextmenu;
-import android.app.Activity;
import android.content.Context;
import android.text.TextUtils;
import android.util.Pair;
@@ -27,13 +26,12 @@ public class PlatformContextMenuUi implements ContextMenuUi {
}
@Override
- public void displayMenu(Activity activity, ContextMenuParams params,
- List<Pair<Integer, List<ContextMenuItem>>> itemGroups,
- final Callback<Integer> listener) {
-
+ public void displayMenu(Context context, ContextMenuParams params,
+ List<Pair<Integer, List<ContextMenuItem>>> itemGroups, final Callback<Integer> listener,
+ Runnable onMenuShown, Runnable onMenuClosed) {
String headerText = ChromeContextMenuPopulator.createHeaderText(params);
if (!TextUtils.isEmpty(headerText)) {
- setHeaderText(activity, mMenu, headerText);
+ setHeaderText(context, mMenu, headerText);
}
MenuItem.OnMenuItemClickListener menuListener = new MenuItem.OnMenuItemClickListener() {
@@ -47,7 +45,7 @@ public class PlatformContextMenuUi implements ContextMenuUi {
List<ContextMenuItem> group = itemGroups.get(groupIndex).second;
for (int itemIndex = 0; itemIndex < group.size(); itemIndex++) {
ContextMenuItem item = group.get(itemIndex);
- MenuItem menuItem = mMenu.add(0, item.menuId, 0, item.getString(activity));
+ MenuItem menuItem = mMenu.add(0, item.menuId, 0, item.getString(context));
menuItem.setOnMenuItemClickListener(menuListener);
}
}

Powered by Google App Engine
This is Rietveld 408576698